We examine the impact of Chinese import competition on patenting, IT, RD and second it reallocated employment between firms towards more innovative and technologically advanced firms. These within and between effects were about equal in magnitude, and appear to account for around 15% of European technology upgrading between 2000-2007. Rising Chinese import competition also led to falls in employment, profits, prices and the skill share. By contrast, import competition from developed countries had no effect on innovation. We develop a simple trapped factor model of innovation that is consistent with these empirical findings.